Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aoi based inference #3

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Aoi based inference #3

wants to merge 9 commits into from

Conversation

pt20
Copy link
Owner

@pt20 pt20 commented Aug 31, 2021

This PR:

  • adds new inference logic
  • implements the real inference logic into the endpoint in a limited sense. That is - for now providing the predefined aoi and image uri

@pt20 pt20 requested a review from mindflayer August 31, 2021 08:17
# resizing the image to be at least 256x256 and then cropping from the center
# size = (256, 256)
# image = ImageOps.fit(image, size, Image.ANTIALIAS)
print(image.shape)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general you should use logging instead of printing to stdout, but all those print calls look like debugging to me.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I forgot to remove the print statement meant for debugging.

@mindflayer
Copy link
Collaborator

Sorry for the late review but I'm in Switzerland at my company's head quarter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants