File Search Bar #3926
File Search Bar #3926
Conversation
resources/scripts/components/server/files/FileManagerContainer.tsx
Outdated
Show resolved
Hide resolved
resources/scripts/components/server/files/FileManagerContainer.tsx
Outdated
Show resolved
Hide resolved
resources/scripts/components/server/files/FileManagerContainer.tsx
Outdated
Show resolved
Hide resolved
resources/scripts/components/server/files/FileManagerContainer.tsx
Outdated
Show resolved
Hide resolved
resources/scripts/components/server/files/FileManagerContainer.tsx
Outdated
Show resolved
Hide resolved
resources/scripts/components/server/files/FileManagerContainer.tsx
Outdated
Show resolved
Hide resolved
resources/scripts/components/server/files/FileManagerContainer.tsx
Outdated
Show resolved
Hide resolved
|
Implementation is not very good. It covers directory names, and it also can't search in directories |
Directory name issue fixed in 43d44da. Also I am able to search in directories. |
|
You can search when you're inside a folder, but not when you're in the main directory and want to search in other directories. I was the one that made the issue about this feature request, and that is the way I had in mind. |
From what I can tell this is only possible with modifications to wings as only the files/folders the user is viewing are sent by wings. |
|
How does it look on mobile? |
Like this |
|
Does the searchbar still overlap the filestructurr breadcrumbs, on desktop? |
Nope |
Glad to hear. I however feel that the mobile version should have a little more work done, so that it matches with the quality of the rest of the ui |
| @@ -36,7 +36,7 @@ export default ({ renderLeft, withinFileEditor, isNewFile }: Props) => { | |||
| }); | |||
|
|
|||
| return ( | |||
| <div css={tw`flex flex-grow-0 items-center text-sm text-neutral-500 overflow-x-hidden`}> | |||
| <div css={tw`flex flex-grow-0 items-center text-sm text-neutral-500`}> | |||
There was a problem hiding this comment.
The directory path would be masked by the input field if overflow-x-hidden was present.
resources/scripts/components/server/files/FileManagerContainer.tsx
Outdated
Show resolved
Hide resolved
resources/scripts/components/server/files/FileManagerContainer.tsx
Outdated
Show resolved
Hide resolved
resources/scripts/components/server/files/FileManagerContainer.tsx
Outdated
Show resolved
Hide resolved
resources/scripts/components/server/files/FileManagerContainer.tsx
Outdated
Show resolved
Hide resolved
|
Updated UI: Mobile: |
|
Nice work! |
|
@matthewpi Could you review this when you have time |
Co-authored-by: Matthew Penner <[email protected]>
mrxbox98
force-pushed
the
feature/PTDL-3503
branch
from
0baf237 to
6f5fb09
Compare
This pr adds a search bar to the file manager.
closes #3503