-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Closes #1831 - Add an artisan command to create an API key from the command line #5055
base: develop
Are you sure you want to change the base?
feature: Closes #1831 - Add an artisan command to create an API key from the command line #5055
Conversation
adding decryption of the key; Adding file output option
You aren't actually checking the user password. IMO the command should only be able to create application api keys. |
I do understand, I am going to make the changes towards the authentication of the user. |
Actually, I am questionning if I should be authenticating the user here because of the fact that it's especially for the admin panel on the installation. It will most likely used right after the creation of the admin user for the Panel and would assing the token to it. If I am loggin in the user, should I use the |
Yeah, for just application api keys I don't see a reason for any auth. |
Don't know if new management has decided to reverse the decision, but they were deprecated by Dane, the comment is no mistake. |
This PR add an artisan command that allows for someone to create an API key from the command line.
This allows the creation of both a (deprecated)
ApiKey::TYPE_APPLICATION
and aApiKey::TYPE_ACCOUNT
.The
TYPE_APPLICATION
key may be needed in cases where someone would want to automate the deployment of the panel and Wings instances without using the Panel which is the case when you want to deploy the project using a tool like Ansible, thus why it was implemented even though Deprecated.