Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only count hard-links once when calculating filesystem usage #181

Merged
merged 5 commits into from
Jun 29, 2024

Conversation

EpicPlayerA10
Copy link
Contributor

@EpicPlayerA10 EpicPlayerA10 commented Feb 29, 2024

Wings sums up all hard links sizes to the total disk space usage. This PR adds that it will only add one of them and other ones that point to the same file will be skipped.

This fixes the bug where when you had a very big file and you created a hard link to it then pterodactyl thinks that there are two separate files with the same size, but they are pointing to the same space on the disk. On panel it would show up higher disk usage than it actually is.

@EpicPlayerA10 EpicPlayerA10 changed the title Don't add hard links size twice Don't sum up hard links size twice Mar 13, 2024
@EpicPlayerA10
Copy link
Contributor Author

Is there any interest in merging this?

@danny6167
Copy link
Member

Is there any interest in merging this?

Thanks for submitting this. I've validated this PR and I'm hoping to get it merged soon.

@matthewpi matthewpi changed the title Don't sum up hard links size twice fix: only count hard-links once when calculating filesystem usage Jun 29, 2024
@matthewpi matthewpi merged commit 1d8b383 into pterodactyl:develop Jun 29, 2024
6 checks passed
dannyhpy pushed a commit to dannyhpy/pterodactyl-wings that referenced this pull request Jul 5, 2024
paulohgodinho pushed a commit to paulohgodinho/wings that referenced this pull request Jul 7, 2024
…erodactyl#181)

docker: add option to NOT create IPV6 interface in the network used by servers

Logging to check if this is working

Properly disabling ipv6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🧨 Awaiting release
Development

Successfully merging this pull request may close these issues.

3 participants