fix: properly use base2 (1024, *bibyte) when calculating memory limits #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Panel gives memory limits in mebibytes (MiB) but Wings considered they were megabytes (MB).
ArnaudLier
force-pushed
the
fix-memory-limits
branch
from
36f7d65
to
32d13aa
Compare
|
Looks good and works as intended, but I feel like we could get rid of that const and just hard code those values as it's only 3 locations in one file. |
It makes the intention a little bit clearer in my opinion but I can inline it if you want. |
|
Yeah lets inline to keep consistent with the existing code. Thanks :) |
|
Thanks. I've dropped it in the awaiting merge queue |
matthewpi
changed the title
dannyhpy
pushed a commit
to dannyhpy/pterodactyl-wings
that referenced
this pull request
Jul 5, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Panel gives memory limits in mebibytes (MiB) but Wings considered they were megabytes (MB).