fix: overhaul docker container termination signals #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses strings to reference signals - This is what docker API is expecting Rename and Replace Terminate() so we aren't assuming the container immediately dies just because we sent it a signal ^C is now considered a SIGINT (as it should be) however this wont take effect until the panel is updated - use ^SIGINT in egg stop instead
danny6167
changed the title
matthewpi
approved these changes
Jun 29, 2024
matthewpi
changed the title
dannyhpy
pushed a commit
to dannyhpy/pterodactyl-wings
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the stop signal handling in wings. Resolves pterodactyl/panel#4783
The docker API actually expects stings and not the os.signal datatypes we are currently passing though.
This change also make ^C properly an alias of ^SIGINT as it should be, but this part will require a panel change as well to prevent the panel from mangling this before it reaches wings.