Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 2.0.0 #43

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from
Open

[WIP] 2.0.0 #43

wants to merge 23 commits into from

Conversation

pthrasher
Copy link
Owner

Prep

  • Create Gruntfile
  • Install grunt deps as dev dependencies
  • Remove Cakefile
  • Convert tests from nodeunit to jasmine as legacy tests. (need to pass for backward compatibility)
  • Remove old tests
  • Break non-core components out into separate files.
  • re-indent with 4-space tabstops, not 2
  • ensure code passes coffeelint
  • Setup in travis ci
  • Add tests for non-core components.

Features

  • Upgrade coffeescript to latest
  • Upgrade uglifyjs to latest
  • Add source map support
  • aliases (Filename patterns #1)
  • Allow array of sources
  • compilerOptions
  • Refactor minification to be far speedier
  • Make mangling optional.
  • wrap source mapping in tests to ensure line numbers always end up where they were expected.

Documentation

  • Put docco in grunt
  • Add documentation to util.coffee
  • Add documentation to minification.coffee
  • Add documentation to compilers.coffee

This was referenced May 16, 2013
@ghost ghost assigned pthrasher May 16, 2013
@adunkman
Copy link

Hey Philip—

How's this going? I'm working on v3 of connect-assets at the moment (well, it got stalled, but then I got nudged about it) and I'd love to start working on including some of these changes in an alpha or something.

@pthrasher
Copy link
Owner Author

@adunkman I was hoping to get it done by the end of may, but ran out of time.

This is definitely on the list of things that need to get done asap. I should have ample time to finish up this PR this month.

Let me know what specifically you'd like included, etc... How the API can be altered (if necessary) to better work with connect-assets...

I definitely look forward to any collaboration we can do on it.

@max-degterev
Copy link

@pthrasher how about pushing some parts that are already complete to the npm? It haven't been updated in a year and devs like me would totally appreciate some new awesomeness 👍

@rstacruz
Copy link

rstacruz commented Oct 8, 2013

Need any help? :)

@pthrasher
Copy link
Owner Author

@rstacruz Always up for help!

I want to dig back into this, as I really need this to be working in tip top shape. However, I feel there's a need to break things up into a different set of components.

Basically, this thing just isn't really extensible right now, and if you want to do source maps properly with mixed file types, mixed minification, etc... You need to have a broken up toolchain. So some thought needs to be put into that.

@pthrasher
Copy link
Owner Author

Hey guys, I'm back in this, and have also enlisted the help of a colleague. I'll be getting to most of the above things in the next couple of weeks, and likely go ahead and do an incomplete release just to get some of this new stuff out there.

Thanks for being patient

@max-degterev
Copy link

🍻 keep up the good work

@rstacruz
Copy link

👍

@juanghurtado
Copy link

Would be awesome to have all this! 👍 Keep going, man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants