-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add L-BFGS reconstruction engine #485
base: dev
Are you sure you want to change the base?
Conversation
@daurer this L-BFGS pull request is now ready for review and potential merge. |
Needs a CuPy engine before it can be merged. @ptim0626 maybe something for you? |
1686ea0
to
fecdb53
Compare
A quick comment, the tolerance for LBFGS's tests is increased as it is very likely the discrepancy is a result of numerical instability instead of the problem of implementation. |
@daurer this PR will soon need to be updated to use the wavefield preconditioner, I'm happy to do this. |
Resurrecting #400 as GitHub broke the original PR.
Add Limited-memory BFGS reconstruction engine to as an alternative to ML.
Caveats: