feat: contains_many and simplify works with iter of V not just &V #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstin
approved these changes
Feb 2, 2024
|
I rebased which required some intervention due to #183. So while I was looking at it I noticed that we had not made the symmetric change for simplify. So I added that as well. I will give some time for re-review due to the substantive changes. |
Eh2406
changed the title
zanieb
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
containstakes a&V, because if you haven't ownedV(even behind the smart pointerBox/Arc/Cow) it is easy to add a&. Socontains_manycopied that interface and takes an iterator ofItem = &V. Unfortunately, if you have an iterator ofItem = V(orItem =Box/Arc/CowofV) it is not straightforward to get a reference.This came up in the context of semver-pubgrub, whose implementation of contains needs to ignore the
BuildMetadatapart of the semver version. I will be investigating if there are ways to work around this by expressing=x.y.z.preas>=x.y.z.pre, <x.y.z.pre.0. But even ifsemver-pubgrubdoes not need this functionality it doesn't hurt to makecontains_manymore flexible.