Add a Range::iter() method
#187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstin
changed the title
Range.iter() method (#18)Range.iter() method
konstin
force-pushed
the
konsti/add-range-iter
branch
from
3a86fd0 to
cbe0f18
Compare
Eh2406
reviewed
Mar 11, 2024
src/range.rs
Outdated
| @@ -493,6 +493,11 @@ impl<V: Ord + Clone> Range<V> { | |||
| } | |||
| Self { segments }.check_invariants() | |||
| } | |||
|
|
|||
| /// Iterate over the parts of the range. | |||
| pub fn iter(&self) -> impl Iterator<Item = &(Bound<V>, Bound<V>)> { | |||
There was a problem hiding this comment.
Can this be Item = (&Bound<V>, &Bound<V>), so that our API does not require us to store this in a tuple?
There was a problem hiding this comment.
I've checked with uv, we can 👍
Eh2406
approved these changes
Mar 11, 2024
Co-authored-by: Zanie Blue <[email protected]> Otherwise, it's not possible to implement custom formatting of `Range` types. This seems generally useful to expose. Example usages: https://github.com/astral-sh/uv/blob/8d721830db8ad75b8b7ef38edc0e346696c52e3d/crates/uv-resolver/src/pubgrub/report.rs#L97-L112 https://github.com/astral-sh/uv/blob/8d721830db8ad75b8b7ef38edc0e346696c52e3d/crates/uv-resolver/src/pubgrub/report.rs#L549-L560 https://github.com/astral-sh/uv/blob/8d721830db8ad75b8b7ef38edc0e346696c52e3d/crates/uv-resolver/src/pubgrub/report.rs#L568-L605 Upstream port of #18, but `impl Iterator<Item = (&Bound<V>, &Bound<V>)>` instead of `impl Iterator<Item = &(Bound<V>, Bound<V>)>` to avoid constraining it to a tuple.
konstin
force-pushed
the
konsti/add-range-iter
branch
from
cbe0f18 to
58766a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, it's not possible to implement custom formatting of
Rangetypes. This seems generally useful to expose.Example usages:
https://github.com/astral-sh/uv/blob/8d721830db8ad75b8b7ef38edc0e346696c52e3d/crates/uv-resolver/src/pubgrub/report.rs#L97-L112
https://github.com/astral-sh/uv/blob/8d721830db8ad75b8b7ef38edc0e346696c52e3d/crates/uv-resolver/src/pubgrub/report.rs#L549-L560
https://github.com/astral-sh/uv/blob/8d721830db8ad75b8b7ef38edc0e346696c52e3d/crates/uv-resolver/src/pubgrub/report.rs#L568-L605
Upstream port of astral-sh#18