Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove naming convention ci check #220

Merged

Conversation

konstin
Copy link
Member

@konstin konstin commented May 7, 2024

This change switches pubgrub to commit messages without prefix.

Tagging everyone to sign off before merging.

Closes #218

This change switches pbgrub to commit messages without prefix.

Closes pubgrub-rs#218
@konstin konstin requested review from zanieb, mpizenberg and Eh2406 May 7, 2024 15:13
Copy link
Member

@mpizenberg mpizenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t have anything against. It was a good guard rail at some point but I’m also ok with not having it.

@zanieb
Copy link
Member

zanieb commented May 8, 2024

How is the changelog going to work?

@konstin
Copy link
Member Author

konstin commented May 8, 2024

We can start using PR labels. Note that we're not really losing anything, the changelog structure is different than the commit labels

@Eh2406
Copy link
Member

Eh2406 commented May 8, 2024

The previous change logs were maintained manually. As no one volunteered to set up tooling that used the conventional commits. Considering approximately everything has changed since the last public release the next logs is going to be hand authored, even if we had tooling set up. So 🤷

@konstin konstin changed the title Remove naming convetion ci check Remove naming convention ci check May 8, 2024
@zanieb
Copy link
Member

zanieb commented May 8, 2024

Ah if they're not being used for changelog generation than I'm pretty against conventional commit enforcement (but it's not really my project)

@mpizenberg
Copy link
Member

Indeed, this was introduced by Alex, mainly for commit consistency. Considering the (deliberate) few number of releases, it made more sense to me to craft change logs and release notes manually.

@Eh2406 Eh2406 enabled auto-merge May 15, 2024 17:25
Copy link
Member

@Eh2406 Eh2406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can insist on this again in the future when someone wants to use tooling to solve release notes being too big/hard. Until then no need.

@Eh2406 Eh2406 removed the request for review from zanieb May 15, 2024 17:29
@Eh2406 Eh2406 changed the title Remove naming convention ci check ci: remove naming convention ci check May 15, 2024
@Eh2406 Eh2406 added this pull request to the merge queue May 15, 2024
Merged via the queue into pubgrub-rs:dev with commit 1c05803 May 15, 2024
4 checks passed
@konstin konstin deleted the konsti/dev/remove-commit-message-check branch May 15, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI is failing on dev.
4 participants