Return Id<DP::P> over &Id<DP::P>
#295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's more efficient to return a u32 than a reference, and it avoids a borrow when returning it.
konstin
force-pushed
the
konsti/dev/no-id-pointer
branch
from
1a0c3ff to
4739aaf
Compare
konstin
commented
Dec 11, 2024
| @@ -246,8 +246,10 @@ impl<P: Package, VS: VersionSet, M: Eq + Clone + Debug + Display> Incompatibilit | |||
| } | |||
|
|
|||
| /// Iterate over packages. | |||
| pub(crate) fn iter(&self) -> impl Iterator<Item = (&Id<P>, &Term<VS>)> { | |||
| self.package_terms.iter() | |||
| pub(crate) fn iter(&self) -> impl Iterator<Item = (Id<P>, &Term<VS>)> { | |||
There was a problem hiding this comment.
The plan is to expose this iterator from unit propagation and adding dependencies to allow tracking conflicts in the caller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's more efficient to return a u32 than to return a reference, and it avoids a borrow when returning it.