Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support prefunding _before_ renewal window #265

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jason-c-child
Copy link
Contributor

These changes allow pre-funding a name renewal before the renewal window opens. It removes the window check (commented out in case it is desired to reenable in the future...this could potentially be converted into a sudoparam and controlled via gov).

NOTE: there are consequences to this action. Take the following scenario:

1. name renewal is pre-funded
2. renewal window opens 30-days before the renewal deadline
3. valid_bid is made on the name
4. pre-funding amount is > 5% of valid_bid
5. renewal deadline comes, end blocker runs
6. name is renewed
7. excess pre-funded STARS are not returned to the pre-funder

im not sure if this is good or badddd...it just is what would happen. the owner can always refund the excess STARS...however it will not be automatic....

@jason-c-child jason-c-child marked this pull request as ready for review October 9, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants