Update notes_controller_test.rb #11461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Code Climate has analyzed commit 6ba5ea0 and detected 0 issues on this pull request. View more on Code Climate. |
|
HELLO @TildaDares thanks for the feedback but please how would i merge the
two PR
…On Tue, 11 Oct 2022 at 14:30, Tilda Udufo ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hi @belfarz <https://github.com/belfarz>, the changes in this PR and in
#11460 <#11460> needs to be in a
single PR. Thank you!
—
Reply to this email directly, view it on GitHub
<#11461 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3OGLHZKTEWR6L7B3BDZ2LTWCVTV7ANCNFSM6AAAAAARBHX3LI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi @belfarz, since you’re already working on one FTO in publiclab/Leaflet.DistortableImage#1104, maybe we can leave this issue for someone else to work on. Thanks! |
|
Hi @belfarz, contributors are only allowed to work on one FTO. I'll be closing this to give another first-timer a chance to make a contribution. Thank you for your time and effort. We appreciate your contributions. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update notes_controller_test.rb
Fixes #0000
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment below