Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.33.0 to 1.48.0 #11619

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 6, 2023

Bumps rubocop from 1.33.0 to 1.48.0.

Release notes

Sourced from rubocop's releases.

RuboCop 1.48

New features

Bug fixes

  • #11654: Fix a false positive for Lint/MissingSuper when no super call and when defining some method. (@​koic)
  • #11661: Fix an error for Style/Documentation when namespace is a variable. (@​koic)
  • #11647: Fix an error for Style/IfWithBooleanLiteralBranches when using () as a condition. (@​koic)
  • #11646: Fix an error for Style/NegatedIfElseCondition when using () as a condition. (@​koic)
  • #11659: Fix an incorrect autocorrect for Lint/OrAssignmentToConstant when using or-assignment to a constant in method definition. (@​koic)
  • #11663: Fix an incorrect autocorrect for Style/BlockDelimiters when multi-line blocks to { and } with arithmetic operation method chain. (@​koic)
  • #11638: Fix a false positive for Lint/UselessAccessModifier when using same access modifier inside and outside the included block. (@​ydah)
  • #11164: Suppress server mode message with -f json. (@​jasondoc3)
  • #11643: Fix incorrect shorthand autocorrections in calls inside parentheses. (@​gsamokovarov)
  • #11650: Style/AccessorGrouping: Fix detection of Sorbet sig {} blocks. (@​issyl0)
  • #11657: Use cop name to check if cop inside registry is enabled. Previously, it was able to cause large memory usage during linting. (@​fatkodima)

Changes

  • #11482: Avoid comment deletion by Style/IfUnlessModifier when the modifier form expression has long comment. (@​nobuyo)
  • #11649: Support MinBranchesCount config for Style/CaseLikeIf cop. (@​fatkodima)

RuboCop 1.47

New features

Bug fixes

  • #11615: Fix a false negative for Lint/MissingSuper when no super call with Class.new block. (@​koic)
  • #11615: Fix a false negative for Lint/MissingSuper when using Class.new without parent class argument. (@​koic)
  • #11040: Fix a false positive for Style/IfUnlessModifier when defined?'s argument value is undefined. (@​koic)
  • #11607: Fix a false positive for Style/RedundantRegexpEscape when an escaped hyphen follows after an escaped opening square bracket within a character class. ([@​SparLaimor][])
  • #11626: Fix a false positive for Style/ZeroLengthPredicate when using File.new(path).size.zero?. (@​koic)
  • #11620: Fix an error for Lint/ConstantResolution when using __ENCODING__. (@​koic)
  • #11625: Fix an error for Lint/EmptyConditionalBody when missing if body and using method call for return value. (@​koic)
  • #11631: Fix an incorrect autocorrect for Style/ArgumentsForwarding when using arguments forwarding for .() call. (@​koic)
  • #11621: Fix an incorrect autocorrect for Layout/ClassStructure using heredoc inside method. (@​fatkodima)

... (truncated)

Changelog

Sourced from rubocop's changelog.

1.48.0 (2023-03-06)

New features

Bug fixes

  • #11654: Fix a false positive for Lint/MissingSuper when no super call and when defining some method. ([@​koic][])
  • #11661: Fix an error for Style/Documentation when namespace is a variable. ([@​koic][])
  • #11647: Fix an error for Style/IfWithBooleanLiteralBranches when using () as a condition. ([@​koic][])
  • #11646: Fix an error for Style/NegatedIfElseCondition when using () as a condition. ([@​koic][])
  • #11659: Fix an incorrect autocorrect for Lint/OrAssignmentToConstant when using or-assignment to a constant in method definition. ([@​koic][])
  • #11663: Fix an incorrect autocorrect for Style/BlockDelimiters when multi-line blocks to { and } with arithmetic operation method chain. ([@​koic][])
  • #11638: Fix a false positive for Lint/UselessAccessModifier when using same access modifier inside and outside the included block. ([@​ydah][])
  • #11164: Suppress server mode message with -f json. ([@​jasondoc3][])
  • #11643: Fix incorrect shorthand autocorrections in calls inside parentheses. ([@​gsamokovarov][])
  • #11650: Style/AccessorGrouping: Fix detection of Sorbet sig {} blocks. ([@​issyl0][])
  • #11657: Use cop name to check if cop inside registry is enabled. Previously, it was able to cause large memory usage during linting. ([@​fatkodima][])

Changes

  • #11482: Avoid comment deletion by Style/IfUnlessModifier when the modifier form expression has long comment. ([@​nobuyo][])
  • #11649: Support MinBranchesCount config for Style/CaseLikeIf cop. ([@​fatkodima][])

1.47.0 (2023-03-01)

New features

Bug fixes

  • #11615: Fix a false negative for Lint/MissingSuper when no super call with Class.new block. ([@​koic][])
  • #11615: Fix a false negative for Lint/MissingSuper when using Class.new without parent class argument. ([@​koic][])
  • #11040: Fix a false positive for Style/IfUnlessModifier when defined?'s argument value is undefined. ([@​koic][])
  • #11607: Fix a false positive for Style/RedundantRegexpEscape when an escaped hyphen follows after an escaped opening square bracket within a character class. ([@​SparLaimor][])
  • #11626: Fix a false positive for Style/ZeroLengthPredicate when using File.new(path).size.zero?. ([@​koic][])
  • #11620: Fix an error for Lint/ConstantResolution when using __ENCODING__. ([@​koic][])
  • #11625: Fix an error for Lint/EmptyConditionalBody when missing if body and using method call for return value. ([@​koic][])
  • #11631: Fix an incorrect autocorrect for Style/ArgumentsForwarding when using arguments forwarding for .() call. ([@​koic][])
  • #11621: Fix an incorrect autocorrect for Layout/ClassStructure using heredoc inside method. ([@​fatkodima][])
  • #3591: Handle modifier while and until expressions in Lint/UselessAssignment. ([@​bfad][])
  • #11202: Fixed usage of --only flag with --auto-gen-config. ([@​istvanfazakas][])

Changes

  • #11623: Add rubocop-capybara to suggested extensions and extension doc. ([@​ydah][])

... (truncated)

Commits
  • 8d32826 Cut 1.48
  • 36cc776 Update Changelog
  • af8b5f9 [Fix #11164] Suppress server mode message with -f json (#11668)
  • 8257ff2 [Fix #11629] Add new Style/FileEmpty cop
  • f23e487 Cache classname_attribute_value in junit formatter
  • 0499a58 [Fix #11628] Add new Style/DirEmpty cop
  • f982aa8 [Fix #11663] Fix an incorrect autocorrect for Style/BlockDelimiters
  • d8f6765 Merge pull request #11665 from fatkodima/registry-enabled-cop-name
  • 118542b Merge pull request #11638 from ydah/fix-lint_useless_access_modifier
  • 0d3c056 Fix a false positive for Lint/UselessAccessModifier when using same access ...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.33.0 to 1.48.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.33.0...v1.48.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file Ruby labels Mar 6, 2023
@codeclimate
Copy link

codeclimate bot commented Mar 6, 2023

Code Climate has analyzed commit 8ec51d8 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #11619 (cadd2f5) into main (5e1d8c2) will decrease coverage by 3.81%.
The diff coverage is n/a.

❗ Current head cadd2f5 differs from pull request most recent head 8ec51d8. Consider uploading reports for the commit 8ec51d8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11619      +/-   ##
==========================================
- Coverage   83.33%   79.52%   -3.81%     
==========================================
  Files          93       93              
  Lines        5772     5792      +20     
==========================================
- Hits         4810     4606     -204     
- Misses        962     1186     +224     
Impacted Files Coverage Δ
app/channels/application_cable/channel.rb 0.00% <0.00%> (-100.00%) ⬇️
app/channels/application_cable/connection.rb 0.00% <0.00%> (-100.00%) ⬇️
app/channels/user_channel.rb 0.00% <0.00%> (-83.34%) ⬇️
app/channels/user_notification_channel.rb 0.00% <0.00%> (-83.34%) ⬇️
app/channels/room_channel.rb 0.00% <0.00%> (-71.43%) ⬇️
app/helpers/comment_helper.rb 34.61% <0.00%> (-65.39%) ⬇️
app/controllers/openid_controller.rb 16.23% <0.00%> (-37.67%) ⬇️
app/controllers/comment_controller.rb 66.92% <0.00%> (-16.16%) ⬇️
app/controllers/subscription_controller.rb 63.00% <0.00%> (-13.00%) ⬇️
app/controllers/application_controller.rb 84.37% <0.00%> (-6.25%) ⬇️
... and 18 more

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 16, 2023

Superseded by #11659.

@dependabot dependabot bot closed this Oct 16, 2023
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-1.48.0 branch October 16, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Ruby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants