Clen 1924: support for pagination params for push channels #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohitpubnub
added
status: done
jguz-pubnub
reviewed
Mar 28, 2024
|
|
||
| ListPushChannelsParams(this.keyset, this.deviceId, this.pushGateway, | ||
| {this.topic, this.environment}); | ||
| {this.topic, this.environment, this.start, this.count}); |
There was a problem hiding this comment.
Nitpick, you can add a trailing comma , after this.count so your IDE should break the line
jguz-pubnub
reviewed
Mar 28, 2024
pubnub/lib/src/dx/push/push.dart
Outdated
| @@ -33,7 +37,7 @@ mixin PushNotificationDx on Core { | |||
| if (gateway == PushGateway.apns2) Ensure(topic).isNotNull('topic'); | |||
|
|
|||
| var params = ListPushChannelsParams(keyset, deviceId, gateway, | |||
| topic: topic, environment: environment); | |||
| topic: topic, environment: environment, start: start, count: count); | |||
There was a problem hiding this comment.
The same nitpick here, you can add a trailing comma , after count so your IDE should break the line
jguz-pubnub
reviewed
Mar 28, 2024
pubnub/test/unit/dx/push_test.dart
Outdated
| test('listPushChannels delegate supported arguments', () async { | ||
| fakePubnub.returnWhen( | ||
| #listPushChannels, | ||
| Future.value( |
There was a problem hiding this comment.
You can also use trailing commas here, I leave it up to you
jguz-pubnub
reviewed
Mar 28, 2024
|
|
||
| expect(invocation.isMethod, equals(true)); | ||
| expect(invocation.memberName, equals(#listPushChannels)); | ||
| expect(invocation.positionalArguments, |
There was a problem hiding this comment.
You can also use trailing commas here, I leave it up to you
jguz-pubnub
approved these changes
Mar 28, 2024
|
Yeah!! The commas |
|
@pubnub-release-bot release dart as v4.3.3 |
kazydek
reviewed
Mar 28, 2024
kazydek
approved these changes
Mar 28, 2024
Co-authored-by: Karolina Rymer <[email protected]>
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Added support for pagination params for listChannels api of push notification devices.
Added support for pagination params for listChannels api of push notification devices.