Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix readme git package usage #51

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix readme git package usage #51

wants to merge 2 commits into from

Conversation

nickmeinhold
Copy link

@nickmeinhold nickmeinhold commented Jun 3, 2021 •
edited
Loading

Hello and thank you for your work!

When I follow the instructions in the README on adding the dependency as a Git package, I get the following error:

Resolving dependencies...
Could not find a file named "pubspec.yaml" in git://github.com/pubnub/dart.git 01a375fc5f1ad744fbd3df92aa9c8b6d5ab74fed.
pub finished with exit code 1

I have updated the README with what I believe is the correct usage in this case.

Thanks!

are
are approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@are are left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for opening the PR! You are absolutely correct, that part of README needed to be updated! We will incorporate your changes in the next release.

@are are self-assigned this Jun 3, 2021
@are are added status: accepted This issue is accepted as valid, but it's not being worked on yet. type: documentation This issue requests a change in documentation. labels Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@are are are approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@are are

Labels
status: accepted This issue is accepted as valid, but it's not being worked on yet. type: documentation This issue requests a change in documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickmeinhold @are