New method for computing User updates that uses ETag #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcin-cebo
approved these changes
Jan 20, 2025
| email = previousUser.email + "1" | ||
| custom = createCustomObject(previousUser.custom!! + ("abc" to 1)) | ||
| type = previousUser.type + "1" | ||
| status = previousUser.status + "1" |
There was a problem hiding this comment.
What will happen when on server status is null and here we don't specify it? Will it be set to null on server?
There was a problem hiding this comment.
setting null to any field here means "no change", which is unrelated to changes in this PR and consistent with how setUUIDMetadata always worked in our SDKs
that's because our SDKs (Kotlin, Swift, JS) don't currently actually support setting a field to null. We'd need to change the SDKs to start supporting something like PatchValue (that we have for reading data) for setting data. And then there'd be a difference between PatchValue.of(null) and just null (no change).
Fixes the problem of overwriting custom data at regular intervals when `storeUserActivityInterval` is enabled.
wkal-pubnub
force-pushed
the
wkal/use_etag_user
branch
from
335c764 to
bfdde76
Compare
|
@pubnub-release-bot release kotlin as 0.11.0 |
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Added a new version of
User.updatethat can be used to update data on the server without losing intermediate updates that might have happened in the time between when the object was last received and updated.feat: Added the ability to mute and unmute users through
Chat.mutedUsers.muteUser() / unmuteUser()feat: Added the option to automatically sync the mute list using App Context by enabling
ChatConfiguration.syncMutedUsersfeat: Added missing function to parse quoted message text into parts.
fix: Fixes the problem of overwriting custom data at regular intervals when
storeUserActivityIntervalis enabled.