This repository has been archived by the owner on Oct 24, 2018. It is now read-only.
Show total registrations, and separate out some code into new file #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The routes/registration.js file is getting unmanageably large. Rather than moving the completely to utils.ks and making that too large, I'd like to collect the registration-specific helper functions into a new place.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I began working on #205, realised registration.js was becoming huge, and wanted to tackle that somehow. Creating a new file to hold all the registration utility functions seems like the first step. Ideally we would then reduce the size by adding clever helper functions to models/registration.js, but I don't have a clear idea of how to do that