Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklight upgrade to 8.6.1 #4582

Merged
merged 6 commits into from
Dec 30, 2024
Merged

Blacklight upgrade to 8.6.1 #4582

merged 6 commits into from
Dec 30, 2024

Conversation

@christinach christinach mentioned this pull request Nov 18, 2024
6 tasks
Gemfile.lock Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Nov 18, 2024

Coverage Status

coverage: 95.807% (-0.7%) from 96.486%
when pulling 1c35b03 on Blacklight8-upgrade-v2
into b79cbcd on main.

@christinach christinach force-pushed the Blacklight8-upgrade-v2 branch 6 times, most recently from 557b870 to 07dd462 Compare November 25, 2024 20:53
@christinach christinach force-pushed the Blacklight8-upgrade-v2 branch 4 times, most recently from 0139572 to 1c08083 Compare November 27, 2024 22:20
@christinach christinach force-pushed the Blacklight8-upgrade-v2 branch from 1c08083 to 047e757 Compare December 4, 2024 15:44
@christinach christinach force-pushed the Blacklight8-upgrade-v2 branch from 25fa66e to 9d20f65 Compare December 9, 2024 20:25
@christinach christinach force-pushed the Blacklight8-upgrade-v2 branch from 9d20f65 to 878d522 Compare December 9, 2024 23:14
@christinach christinach force-pushed the Blacklight8-upgrade-v2 branch 2 times, most recently from 7745ae7 to 3b8db22 Compare December 12, 2024 22:07
@christinach christinach force-pushed the Blacklight8-upgrade-v2 branch 3 times, most recently from 43dcae8 to 4b9b318 Compare December 16, 2024 18:57
@christinach christinach force-pushed the Blacklight8-upgrade-v2 branch from 4b9b318 to 004d4ea Compare December 17, 2024 15:02
christinach and others added 6 commits December 30, 2024 15:16
Co-authored-by: Jane Sandberg <[email protected]>
Co-authored-by: Max Kadel <[email protected]>
… for when the form is submitted successfully in AJAX

Find the show.blacklight.blacklight-modal in
https://github.com/projectblacklight/blacklight/blob/main/app/javascript/blacklight-frontend/modal.js#L188

Co-authored-by: Jane Sandberg <[email protected]>
Co-authored-by: Christina Chortaria <[email protected]>
…rb and

app/views/catalog/_suggest_correction_form.html.erb with remote:true
Test feedback form modal with the event listener addition on the blacklight-modal
Mark spec/fetaures/report_harmful_language_spec as pending because of #4655

Co-authored-by: Jane Sandberg <[email protected]>
@christinach christinach force-pushed the Blacklight8-upgrade-v2 branch from d6bf973 to 1c35b03 Compare December 30, 2024 20:17
@christinach christinach marked this pull request as ready for review December 30, 2024 20:17
Copy link
Member

@sandbergja sandbergja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo hoo!

@sandbergja sandbergja merged commit 13ebc1c into main Dec 30, 2024
13 of 14 checks passed
@sandbergja sandbergja deleted the Blacklight8-upgrade-v2 branch December 30, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants