-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blacklight upgrade to 8.6.1 #4582
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkadel
reviewed
Nov 18, 2024
christinach
force-pushed
the
Blacklight8-upgrade-v2
branch
6 times, most recently
from
November 25, 2024 20:53
557b870
to
07dd462
Compare
christinach
force-pushed
the
Blacklight8-upgrade-v2
branch
4 times, most recently
from
November 27, 2024 22:20
0139572
to
1c08083
Compare
christinach
force-pushed
the
Blacklight8-upgrade-v2
branch
from
December 4, 2024 15:44
1c08083
to
047e757
Compare
christinach
force-pushed
the
Blacklight8-upgrade-v2
branch
from
December 9, 2024 20:25
25fa66e
to
9d20f65
Compare
christinach
force-pushed
the
Blacklight8-upgrade-v2
branch
from
December 9, 2024 23:14
9d20f65
to
878d522
Compare
christinach
force-pushed
the
Blacklight8-upgrade-v2
branch
2 times, most recently
from
December 12, 2024 22:07
7745ae7
to
3b8db22
Compare
christinach
force-pushed
the
Blacklight8-upgrade-v2
branch
3 times, most recently
from
December 16, 2024 18:57
43dcae8
to
4b9b318
Compare
christinach
force-pushed
the
Blacklight8-upgrade-v2
branch
from
December 17, 2024 15:02
4b9b318
to
004d4ea
Compare
1 task
christinach
force-pushed
the
Blacklight8-upgrade-v2
branch
3 times, most recently
from
December 24, 2024 19:07
04c8569
to
d6bf973
Compare
Co-authored-by: Jane Sandberg <[email protected]> Co-authored-by: Max Kadel <[email protected]>
… for when the form is submitted successfully in AJAX Find the show.blacklight.blacklight-modal in https://github.com/projectblacklight/blacklight/blob/main/app/javascript/blacklight-frontend/modal.js#L188 Co-authored-by: Jane Sandberg <[email protected]> Co-authored-by: Christina Chortaria <[email protected]>
…rb and app/views/catalog/_suggest_correction_form.html.erb with remote:true Test feedback form modal with the event listener addition on the blacklight-modal Mark spec/fetaures/report_harmful_language_spec as pending because of #4655 Co-authored-by: Jane Sandberg <[email protected]>
christinach
force-pushed
the
Blacklight8-upgrade-v2
branch
from
December 30, 2024 20:17
d6bf973
to
1c35b03
Compare
sandbergja
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woo hoo!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the blacklight 8 upgrade branch.
Current issues that need to be fixed: