Catch when patron_hash is TrueClass #4647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkadel
reviewed
Dec 17, 2024
app/models/requests/patron.rb
Outdated
| @@ -94,7 +94,10 @@ def to_h | |||
|
|
|||
| def load_patron(user:) | |||
| patron_hash = current_patron_hash(user.uid) | |||
| errors << "A problem occurred looking up your library account." if patron_hash.blank? | |||
| if patron_hash.instance_of?(TrueClass) || patron_hash.blank? | |||
There was a problem hiding this comment.
For me, it would make more sense if we caught this error lower down in the stack trace, and make sure that this method doesn't get a patron_hash that's an instance of TrueClass.
This reverts commit e6f8fa0.
sandbergja
requested changes
Dec 17, 2024
There was a problem hiding this comment.
Thanks, @rladdusaw -- I agree with @maxkadel that we should catch this at a lower level if possible. I think it would be beneficial for two reasons:
- Hopefully we could avoid having a type check, and
- TrueClass gives the vibes of something happened successfully -- at least to me-- so I find it counterintuitive here that it actually means that getting the hash errored. It would be nice if we could avoid that.
app/models/requests/patron.rb
Outdated
| @@ -94,7 +94,10 @@ def to_h | |||
|
|
|||
| def load_patron(user:) | |||
| patron_hash = current_patron_hash(user.uid) | |||
| errors << "A problem occurred looking up your library account." if patron_hash.blank? | |||
| if patron_hash.instance_of?(TrueClass) || patron_hash.blank? | |||
Co-authored-by: Max Kadel <[email protected]>
sandbergja
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4581