Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe iDMA instantiation: guard against parameters mismatches #59

Open
colluca opened this issue Aug 31, 2024 · 0 comments
Open

Safe iDMA instantiation: guard against parameters mismatches #59

colluca opened this issue Aug 31, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@colluca
Copy link
Contributor

colluca commented Aug 31, 2024

When instantiating idma_backend_rw_axi care has to be taken to pass the same AR channel through parameters read_meta_channel_t and axi_req_t.

In particular, during iDMA integration in Occamy to replace the legacy system DMA, read_meta_channel_t was wrongly misconfigured to use the AR channel from the frontend configuration interface, and the ID width mismatch would lead to malformed AXI requests from the backend.

I don't understand the need for the two somewhat redundant parameters, but I can think of two solutions to make instantiating the iDMA less error-prone:

  • provide wrappers which instantiate frontend, midend and backend, deriving "redundant" parameters internally
  • add assertion checks within the backend or transport layers to verify that "redundant" parameters match

I think the first would be the most valuable approach, but the second might still be valuable for iDMA developers in the development phase.

@colluca colluca added the enhancement New feature or request label Aug 31, 2024
@colluca colluca changed the title Add assertion checks on parameters required to match Safe iDMA instantiation: guard against parameters mismatches Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant