Bump the pulp-cli requirement #95
Conversation
|
Be sure to read the changelog: https://staging-docs.pulpproject.org/pulp-cli/changes/changelog/#0.25.0-pulp-glue-removal |
lubosmj
force-pushed
the
bump-up-pulp-cli-dep
branch
7 times, most recently
from
6316918 to
cb56156
Compare
This requirement is necessary to bump in order to install pulp-cli-glue==0.25. [noissue]
lubosmj
force-pushed
the
bump-up-pulp-cli-dep
branch
from
cb56156 to
37690f9
Compare
|
@mdellweg, do you think I missed out something here? We should release this to really support pulp-glue 0.25 because the last version pins pulp-cli to Also, it is quite surprising that the version in |
| __version__ = "0.2.0.dev" | ||
| __version__ = "0.4.0.dev" |
There was a problem hiding this comment.
It's missing from https://github.com/pulp/pulp-cli-ostree/blob/main/.bumpversion.cfg. So yes you need to sync it manually at least now.
But at this point rather than fixing .bumpversion.cfg, I'd suggest running
../pulp-cli/cookiecutter/apply_templates.py to upgrade to using bump-my-version.
| @@ -9,43 +9,50 @@ | |||
| PulpRemoteContext, | |||
| PulpRepositoryContext, | |||
| PulpRepositoryVersionContext, | |||
| registered_repository_contexts, | |||
| PLUGIN = "ostree" | ||
| RESOURCE_TYPE = "commit" |
| NEEDS_PLUGINS = [PluginRequirement("ostree", min="2.0.0")] | ||
| NEEDS_PLUGINS = [PluginRequirement("ostree", specifier=">=2.0.0")] |
| def preprocess_entity(self, body: EntityDefinition, partial: bool = False) -> EntityDefinition: | ||
| body = super().preprocess_entity(body, partial) |
| translation = get_translation(__package__) | ||
| _ = translation.gettext |
There was a problem hiding this comment.
technically not needed, but I'm looking forward to the slovakian translation files. ;)
| distribution_ctx.update(href, body={"repository": ""}, non_blocking=True) | ||
| distribution_ctx.update(body={"repository": ""}, non_blocking=True) |
| from pulp_glue.common.i18n import get_translation | ||
| from pulp_glue.core.context import PulpArtifactContext |
There was a problem hiding this comment.
Ohhh, this could have changed from the first incarnation of pulp_glue...
👍
| repository_option, | ||
| repository_lookup_option, |
There was a problem hiding this comment.
👍
Sneaky feature creep... (I think this allows "name or version").
| if pulp debug has-plugin --name "ostree" --min-version "2.2.0" | ||
| if pulp debug has-plugin --name "ostree" --specifier ">=2.2.0" |
[noissue]
lubosmj
force-pushed
the
bump-up-pulp-cli-dep
branch
from
c80a435 to
950a26f
Compare
| - python: "3.11" | ||
| image_tag: "nightly" | ||
| - image_tag: "nightly" | ||
| pulp_api_root: "/relocated/djnd/" | ||
| - python: "3.8" | ||
| image_tag: "3.28" | ||
| python: "3.11" | ||
| - image_tag: "3.28" | ||
| lower_bounds: true | ||
| - python: "3.12" | ||
| image_tag: "3.26" | ||
| - python: "3.8" | ||
| image_tag: "3.25" | ||
| - python: "3.9" | ||
| image_tag: "3.24" | ||
| python: "3.8" | ||
| - image_tag: "3.26" | ||
| python: "3.12" | ||
| - image_tag: "3.25" | ||
| python: "3.8" | ||
| - image_tag: "3.24" | ||
| pulp_api_root: "/relocated/djnd/" | ||
| - python: "3.10" | ||
| image_tag: "3.35" | ||
| - python: "3.11" | ||
| image_tag: "latest" | ||
| python: "3.9" | ||
| - image_tag: "3.35" | ||
| python: "3.10" | ||
| - image_tag: "latest" | ||
| lower_bounds: true | ||
| python: "3.11" |
There was a problem hiding this comment.
Ah right dictionaries sorted by keys for stability...
(should be the same as before otherwise.)
| {% endif %} | ||
|
|
||
| {% if sections[section] %} | ||
| {% for category, val in definitions.items() if category in sections[section]%} | ||
| #### {{ definitions[category]['name'] }} | ||
| #### {{ definitions[category]['name'] }} {: #{{versiondata.version}}{{section_slug}}-{{category}} } |
There was a problem hiding this comment.
While being a good change, this may or may not lead to a one time hickup when collecting changelogs from previous branches.
At this time, just something to keep an eye on.
This requirement is necessary to bump in order to install pulp-cli-glue==0.25.
[noissue]