Add 'set -eu' for test script robustness

pulp · Mar 10, 2025 · c543512 · c543512
1 parent f7ba1cb
commit c543512
Show file tree

Hide file tree

Showing 65 changed files with 66 additions and 7 deletions.
diff --git a/tests/scripts/pulp_2to3_migration/test_plan.sh b/tests/scripts/pulp_2to3_migration/test_plan.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_2to3_migration/test_pulp2.sh b/tests/scripts/pulp_2to3_migration/test_pulp2.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_ansible/test_content.sh b/tests/scripts/pulp_ansible/test_content.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_ansible/test_distribution.sh b/tests/scripts/pulp_ansible/test_distribution.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_ansible/test_remote.sh b/tests/scripts/pulp_ansible/test_remote.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_ansible/test_repository.sh b/tests/scripts/pulp_ansible/test_repository.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_ansible/test_sign.sh b/tests/scripts/pulp_ansible/test_sign.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_ansible/test_sync.sh b/tests/scripts/pulp_ansible/test_sync.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_container/test_content.sh b/tests/scripts/pulp_container/test_content.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_container/test_copy.sh b/tests/scripts/pulp_container/test_copy.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_container/test_distribution.sh b/tests/scripts/pulp_container/test_distribution.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_container/test_namespace.sh b/tests/scripts/pulp_container/test_namespace.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_container/test_remote.sh b/tests/scripts/pulp_container/test_remote.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_container/test_repository.sh b/tests/scripts/pulp_container/test_repository.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_container/test_role.sh b/tests/scripts/pulp_container/test_role.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_container/test_sync.sh b/tests/scripts/pulp_container/test_sync.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_container/test_tag.sh b/tests/scripts/pulp_container/test_tag.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_file/test_acs.sh b/tests/scripts/pulp_file/test_acs.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_file/test_content.sh b/tests/scripts/pulp_file/test_content.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_file/test_content_bulk.sh b/tests/scripts/pulp_file/test_content_bulk.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_file/test_distribution.sh b/tests/scripts/pulp_file/test_distribution.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_file/test_label.sh b/tests/scripts/pulp_file/test_label.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_file/test_publication.sh b/tests/scripts/pulp_file/test_publication.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_file/test_remote.sh b/tests/scripts/pulp_file/test_remote.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_file/test_repository.sh b/tests/scripts/pulp_file/test_repository.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_file/test_role.sh b/tests/scripts/pulp_file/test_role.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_file/test_sync.sh b/tests/scripts/pulp_file/test_sync.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_python/test_content.sh b/tests/scripts/pulp_python/test_content.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_python/test_distribution.sh b/tests/scripts/pulp_python/test_distribution.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_python/test_publication.sh b/tests/scripts/pulp_python/test_publication.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_python/test_remote.sh b/tests/scripts/pulp_python/test_remote.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_python/test_repository.sh b/tests/scripts/pulp_python/test_repository.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_python/test_sync.sh b/tests/scripts/pulp_python/test_sync.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_rpm/test_acs.sh b/tests/scripts/pulp_rpm/test_acs.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_rpm/test_comps.sh b/tests/scripts/pulp_rpm/test_comps.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_rpm/test_content.sh b/tests/scripts/pulp_rpm/test_content.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_rpm/test_copy.sh b/tests/scripts/pulp_rpm/test_copy.sh
@@ -1,6 +1,6 @@
 #!/bin/bash
-# src1 src2 dest1 dest2 pkg advisory
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 
@@ -99,5 +99,3 @@ cat << EOF >  ./cli_copy_test.json
 ]
 EOF
 expect_succ pulp rpm copy --config @./cli_copy_test.json
-
-
diff --git a/tests/scripts/pulp_rpm/test_prune.sh b/tests/scripts/pulp_rpm/test_prune.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 
@@ -32,6 +33,3 @@ expect_succ pulp rpm prune-packages --repository "rpm:rpm:cli_test_rpm_prune" --
 expect_succ pulp rpm prune-packages --repository "rpm:rpm:cli_test_rpm_prune" --repository "${repo_href}" --repository "${repo_href_2}" --dry-run
 expect_succ pulp rpm prune-packages --all-repositories --dry-run
 expect_succ pulp rpm prune-packages --repository "rpm:rpm:cli_test_rpm_prune" --keep-days 0
-
-
-
diff --git a/tests/scripts/pulp_rpm/test_remote.sh b/tests/scripts/pulp_rpm/test_remote.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_rpm/test_rpm_sync_publish.sh b/tests/scripts/pulp_rpm/test_rpm_sync_publish.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulp_rpm/test_uln_remote.sh b/tests/scripts/pulp_rpm/test_uln_remote.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulpcore/test_access_policy.sh b/tests/scripts/pulpcore/test_access_policy.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulpcore/test_artifact.sh b/tests/scripts/pulpcore/test_artifact.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulpcore/test_cert_guards.sh b/tests/scripts/pulpcore/test_cert_guards.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulpcore/test_content_guards.sh b/tests/scripts/pulpcore/test_content_guards.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulpcore/test_group.sh b/tests/scripts/pulpcore/test_group.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulpcore/test_group_permissions.sh b/tests/scripts/pulpcore/test_group_permissions.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulpcore/test_orphans.sh b/tests/scripts/pulpcore/test_orphans.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulpcore/test_pulpexporter.sh b/tests/scripts/pulpcore/test_pulpexporter.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulpcore/test_pulpimporter.sh b/tests/scripts/pulpcore/test_pulpimporter.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulpcore/test_query_params.sh b/tests/scripts/pulpcore/test_query_params.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulpcore/test_repository_reclaim_space.sh b/tests/scripts/pulpcore/test_repository_reclaim_space.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 
@@ -32,4 +33,4 @@ test "$(echo "$OUTPUT" | jq -r '.[] | select(.relative_path | endswith("1.iso"))
 # Reclaim disk space and verify that the artifact is no longer available
 expect_succ pulp repository reclaim --repository "file:file:cli_test_reclaim_repo"
 expect_succ pulp file repository content list --repository "cli_test_reclaim_repo" --version 1
-test "$(echo "$OUTPUT" | jq -r '.[] | select(.relative_path | endswith("1.iso")) | .artifact')" = "null" 
+test "$(echo "$OUTPUT" | jq -r '.[] | select(.relative_path | endswith("1.iso")) | .artifact')" = "null"
diff --git a/tests/scripts/pulpcore/test_rhsm_cert_guards.sh b/tests/scripts/pulpcore/test_rhsm_cert_guards.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source
 

diff --git a/tests/scripts/pulpcore/test_role.sh b/tests/scripts/pulpcore/test_role.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
+set -eu
 # shellcheck source=tests/scripts/config.source
 . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source