Update base_url in test if content_origin is null #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `content_origin` is not set, the `distribution.base_url` will be defined with the relative path and the curl command in the test script will fail to run because of the missing hostname/address. ref: pulp/pulpcore#6175
Backport to 0.30: 💚 backport PR created✅ Backport PR branch: Backported as #1119 🤖 @patchback |
mdellweg
reviewed
Jan 21, 2025
| # if base_url starts with "/" (relative path) we need to prepend it with the server address | ||
| if [[ $base_url == /* ]] | ||
| then | ||
| base_url="http://localhost:8080${base_url}" |
There was a problem hiding this comment.
It's probably better to use the base url from the config instead of a hardcoded address here.
OTOH, we are not testing the cli with it. We should just remove this part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
content_originis not set, thedistribution.base_urlwill be defined with the relative path and the curl command in the test script will fail to run because of the missing hostname/address.ref: pulp/pulpcore#6175