Add cookiecutter templates for CI #879
Conversation
mdellweg
force-pushed
the
ci_templates
branch
2 times, most recently
from
3c55d63 to
9aeda62
Compare
mdellweg
changed the title
mdellweg
force-pushed
the
ci_templates
branch
from
9aeda62 to
0fba285
Compare
| @@ -0,0 +1,12 @@ | |||
| { | |||
| "app_label": "noname", | |||
There was a problem hiding this comment.
Why is app_label = "noname"?
There was a problem hiding this comment.
The bootstrap part is far from done...
But cookiecutter needs something there, and i wanted to prevent it being empty by default as not to overwrite the pulp-cli repositry accidentally.
| path = "" | ||
| name = "" |
There was a problem hiding this comment.
Are these suppose to be blank?
There was a problem hiding this comment.
yes, that's the main section in the changelog.
| if parse(click.__version__) < parse("8.1.1") or parse(click.__version__) >= parse("8.2"): | ||
| print("🚧 Linting with mypy is currently only supported with click~=8.1.1. 🚧") |
There was a problem hiding this comment.
Remind me again what was the mypy issue with click>=8.2?
There was a problem hiding this comment.
I think they changed some annotations in incompatible ways. I found no way to lint with 8.1.1 and 8.2 simultaneously. Maybe it's time to try again.
There was a problem hiding this comment.
Hah, the answer is much simpler: The latest version of click is 8.1.7.
.ci/scripts/apply_templates.py
Outdated
There was a problem hiding this comment.
How does one bootstrap or apply these templates for other cli plugins?
There was a problem hiding this comment.
no bootstrap today.
You check both repos out next to each other. You cd to the target and call python ../pulp-cli/.ci/apply_templates.py.
mdellweg
force-pushed
the
ci_templates
branch
2 times, most recently
from
32519a1 to
9abb8c7
Compare
mdellweg
force-pushed
the
ci_templates
branch
2 times, most recently
from
684ab75 to
2ababcc
Compare
This should help to keep the CI consistent across multiple cli plugin repositories. [noissue]
mdellweg
force-pushed
the
ci_templates
branch
from
2ababcc to
759cff2
Compare
|
Good discussion around the bootstrap part. It is not ready, so I removed that into another branch. |
This should help to keep the CI consistent across multiple cli plugin repositories.
[noissue]
Review Checklist: