[PULP-715] WIP: Add JSON-based Simple API #956
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
no-changelog
multi-commit
jobselko
force-pushed
the
close_625
branch
2 times, most recently
from
16f7486 to
03e61c7
Compare
github-actions
bot
removed
the
multi-commit
jobselko
force-pushed
the
close_625
branch
2 times, most recently
from
c7e19ec to
6647217
Compare
gerrod3
reviewed
Sep 14, 2025
pulp_python/app/pypi/views.py
Outdated
Comment on lines
278
to
283
| def handle_exception(self, exc): | ||
| # todo: fixes test_pull_through_filter? | ||
| if isinstance(exc, (Http404, NotFound)): | ||
| # Force JSON response since JSONRenderer is not in get_renderers() | ||
| return JsonResponse({"detail": str(exc)}, status=404) | ||
| return super().handle_exception(exc) |
There was a problem hiding this comment.
There's no reason the 404 has to be a JSON response. You could change the test to just check for the error string instead of expecting the result to be json.
| PyPISimpleJSONRenderer(), | ||
| ] | ||
| else: | ||
| return [JSONRenderer(), BrowsableAPIRenderer()] |
There was a problem hiding this comment.
Does super().get_renders() return these values?
pulp_python/app/utils.py
Outdated
| def write_simple_detail_json(project_name, project_packages): | ||
| """Writes the simple detail page in JSON format.""" | ||
| files = [] | ||
| for filename, url, sha256 in project_packages: |
There was a problem hiding this comment.
It might make sense to change project_packages to a list of dictionaries, or namedtuples, and then modify the simple_detail template accordingly.
jobselko
force-pushed
the
close_625
branch
4 times, most recently
from
5f68a09 to
5ad38d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #625