Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PULP-235] Bump minor version #6138

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[PULP-235] Bump minor version #6138

wants to merge 4 commits into from

Conversation

pulpbot
Copy link
Member

@pulpbot pulpbot commented Dec 11, 2024

Automated changes by create-pull-request GitHub action

Comment on lines -337 to -357
def test_emmiting_unblocked_task_telemetry(dispatch_task, pulpcore_bindings, pulp_settings):
# Checking online workers ready to get a task
workers_online = pulpcore_bindings.WorkersApi.list(online="true").count

# We need to generate long running tasks to block the workers from executing other tasks
resident_task_hrefs = [
dispatch_task("pulpcore.app.tasks.test.sleep", args=(30,))
for worker in range(workers_online)
]

# Then we dispatch a quick unblockable task just to keep it waiting in the queue
task_href = dispatch_task("pulpcore.app.tasks.test.sleep", args=(0,))

task = pulpcore_bindings.TasksApi.read(task_href)
assert task.state == "waiting"

[
pulpcore_bindings.TasksApi.tasks_cancel(task_href, {"state": "canceled"})
for task_href in resident_task_hrefs
]

Copy link
Member

@mdellweg mdellweg Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference for future me: Just in case you are wondering why this test get's removed. I has had no guts anymore since we stopped testing for the actual telemetry to arrive somewhere. This is just an empty shell eating CPU cycles.

@mdellweg mdellweg changed the title Bump minor version [PULP-235] Bump minor version Dec 17, 2024
@mdellweg
Copy link
Member

s3 tests are failing for (damn it pip!):

pulp [bbf4f2de-d623-402a-bd22-ec0ce3d24ea8]: pulpcore.tasking.tasks:INFO: Task[pulp_file.app.tasks.publishing.publish] 0193cfe3-c72b-7aaf-9b75-9558903621ab failed (ImproperlyConfigured: Could not load Boto3's S3 bindings. No module named 'dateutil.tz') in domain: default

after

Collecting python-dateutil>=2.8.2 (from pulpcore-client==3.70.0.dev0->-r /tmp/bindings_requirements.txt (line 1))
  Downloading python_dateutil-2.9.0.post0-py2.py3-none-any.whl.metadata (8.4 kB)

and

Installing collected packages: tomli, soupsieve, python-dateutil, pydantic-core, psutil, proxy.py, port-for, pluggy, mock, iniconfig, execnet, exceptiongroup, annotated-types, aiotools, pytest, pydantic, mirakuru, beautifulsoup4, pytest-xdist, pytest-timeout, pytest-redis, pytest-django, pytest-custom_exit_code, pytest-asyncio, pulpcore-client, pulp-file-client, pulp-certguard-client, trustme, pytest-aiohttp
  Attempting uninstall: python-dateutil
    Found existing installation: python-dateutil 2.8.1
    Uninstalling python-dateutil-2.8.1:
      Successfully uninstalled python-dateutil-2.8.1
Successfully installed aiotools-1.7.0 annotated-types-0.7.0 beautifulsoup4-4.12.3 exceptiongroup-1.2.2 execnet-2.1.1 iniconfig-2.0.0 mirakuru-2.5.3 mock-5.1.0 pluggy-1.5.0 port-for-0.7.4 proxy.py-2.4.9 psutil-6.1.0 pulp-certguard-client-3.70.0.dev0 pulp-file-client-3.70.0.dev0 pulpcore-client-3.70.0.dev0 pydantic-2.10.3 pydantic-core-2.27.1 pytest-7.4.4 pytest-aiohttp-1.0.5 pytest-asyncio-0.23.8 pytest-custom_exit_code-0.3.0 pytest-django-4.9.0 pytest-redis-3.0.2 pytest-timeout-2.3.1 pytest-xdist-3.6.1 python-dateutil-2.9.0.post0 soupsieve-2.6 tomli-2.2.1 trustme-1.2.0

when installing the bindings over the application packages.

@mdellweg mdellweg force-pushed the minor-version-bump branch 6 times, most recently from 5fd49b4 to 1b9cf36 Compare December 18, 2024 15:18
@github-actions github-actions bot removed the wip label Dec 18, 2024
@mdellweg
Copy link
Member

So let's see if adjusting the dateutil requirements in our bindings builds solve the last issues.

@mdellweg mdellweg added this to the 3.70.0 blockers milestone Dec 24, 2024
@mdellweg mdellweg force-pushed the minor-version-bump branch from db4272d to 4c27f78 Compare January 2, 2025 10:53
@mdellweg mdellweg force-pushed the minor-version-bump branch 11 times, most recently from 473c421 to c291528 Compare January 2, 2025 17:22
@mdellweg mdellweg force-pushed the minor-version-bump branch from c291528 to b448501 Compare January 2, 2025 18:45
@mdellweg mdellweg enabled auto-merge (rebase) January 2, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants