Allow XMLHttpRequests to prevent password dialogs #6171
+28
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
force-pushed
the
XMLHttpRequest
branch
2 times, most recently
from
3e64f38 to
8c2d039
Compare
When presented a WWW-Authenticate header with "Basic", a browser will always ask the user for a password, before returning the 401 response to the web application issuing the XHR in the first place. Returning a fake authentication method instead seems to be the common workaround pattern.
mdellweg
force-pushed
the
XMLHttpRequest
branch
from
8c2d039 to
d0210d4
Compare
pedro-psb
reviewed
Jan 3, 2025
|
The motivation is, that a web app can indicate this is an AJAX request. This is useful if you want the 401 response to be handed back to the JS part of the application right away (e.g. to redirect to a nice looking login page). Without this, the browser will find the "www-authenticate: Basic" and it will present its password dialog. There is no way to circumvent that on the client side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When presented a WWW-Authenticate header with "Basic", a browser will always ask the user for a password, before returning the 401 response to the web application issuing the XHR in the first place. Returning a fake authentication method instead seems to be the common workaround pattern.