Update django-import-export deps #6372
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dralley
force-pushed
the
django-ie-update
branch
from
c514c3d to
3ca3031
Compare
These have gotten very out of date and it seems like dependabot hasn't worked on them.
dralley
force-pushed
the
django-ie-update
branch
from
3ca3031 to
ce339e4
Compare
mdellweg
reviewed
Mar 19, 2025
| @@ -63,7 +63,7 @@ dependencies = [ | |||
| "python-gnupg>=0.5,<=0.5.4", | |||
| "PyYAML>=5.1.1,<=6.0.2", | |||
| "redis>=4.3,<5.2.2", | |||
| "tablib<3.6.0", | |||
| "tablib>=3.7.0,<3.9.0", | |||
There was a problem hiding this comment.
Should tablib be a direct dependency at all?
There was a problem hiding this comment.
We import it directly here:
pulpcore/pulpcore/app/tasks/importer.py
Line 16 in d563dec
However as long as django-import-export exists we can probably assume its presence? This requirement was primarily here to avoid new incompatible versions, and presumably that's less of an issue with these newer versions?
There was a problem hiding this comment.
Well turning it into a proper dependency with a proper range also sounds good then.
|
Update: we can't update these packages until a breaking change release. I can verify that there are some changed APIs that are exposed to plugins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have gotten very out of date and it seems like dependabot hasn't worked on them.