Mark a failed heartbeat as a catastrophic failure #6612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
force-pushed
the
heartbeats
branch
2 times, most recently
from
e691b82 to
8861004
Compare
This is supposed to dectect situations where the workers fail to reach the database and therefore any type of network partitioning. By theory this should improve consistency in the face of partitioning. It sacrifices only the avaliablility of workers, that would not reach the database anyway to perform anything meaningful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supposed to dectect situations where the workers fail to reach the database and therefore any type of network partitioning. By theory this should improve consistency in the face of partitioning. It sacrifices only the avaliablility of workers, that would not reach the database anyway to perform anything meaningful.