Two small fixes

pulsar-edit · Jun 13, 2024 · 41c3368 · 41c3368
1 parent b5845b7
commit 41c3368
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/layouts/api/method.ejs b/layouts/api/method.ejs
@@ -5,7 +5,7 @@
     let customName = item.customData?.name
   %>
   <section class="api-entry">
-    <h4 class="api-entry__name" data-name="<%= customName ?? "" %>" id="<%= anchorize(item.name) %>">
+    <h4 class="api-entry__name" data-name="<%= customName ?? item.name %>" id="<%= anchorize(item.name) %>">
       <% if (item.customData?.signature) { %>
         <a href="#<%= fragment %>"><%= item.customData.signature %></a>
       <% } else { %>

diff --git a/pulsar-api/src/json2html.js b/pulsar-api/src/json2html.js
@@ -6,6 +6,8 @@ const mdRender = require("./md.js");
 const LAYOUT_DIR = path.resolve(__dirname, "../../layouts/api");
 const ROOT_LAYOUT_DIR = path.resolve(__dirname, "../../layouts");
 
+const hasNoSection = (ele) => ele.sectionName === null;
+
 function convert(name, content, version) {
 
   let file = "";
@@ -63,14 +65,16 @@ function lookupSection(sectionName, prop, content, env) {
 }
 
 function lookupNullSections(content, env, hasOtherSections) {
-  // Originally this directive in the Atom docs would only grab uncategorized methods
-  // but we will look for everything
-  let nullClassMethods = content.classMethods.filter((ele) => ele.sectionName === null);
-  let nullInstanceMethods = content.instanceMethods.filter((ele) => ele.sectionName === null);
-  let nullClassProperties = content.classProperties.filter((ele) => ele.sectionName === null);
-  let nullInstanceProperties = content.instanceProperties.filter((ele) => ele.sectionName === null);
-
-  let totalCount = nullClassProperties.length + nullInstanceMethods.length + nullClassProperties.length + nullInstanceProperties.length;
+  // Originally this directive in the Atom docs would only grab uncategorized
+  // methods — but we will look for everything.
+  let nullClassMethods = content.classMethods.filter(hasNoSection);
+  let nullInstanceMethods = content.instanceMethods.filter(hasNoSection);
+  let nullClassProperties = content.classProperties.filter(hasNoSection);
+  let nullInstanceProperties = content.instanceProperties.filter(hasNoSection);
+
+
+  // Skip rendering anything unless we have at least one uncategorized thing.
+  let totalCount = nullClassMethods.length + nullInstanceMethods.length + nullClassProperties.length + nullInstanceProperties.length;
   if (totalCount === 0) return "";
 
   let file = "";