Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some links #12

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

sogaiu
Copy link

@sogaiu sogaiu commented Oct 14, 2024

This PR contains a few suggested changes to links on the "Developing for Pulsar" page.

Clicking on the links for the following text yield 404s here:

It looks like the intended pages exist and slight modifications seem to work:

Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for the contributions!

I tested this locally and the links are indeed fixed for me.

@DeeDeeG DeeDeeG merged commit d60a1e0 into pulsar-edit:main Oct 14, 2024
@DeeDeeG
Copy link
Member

DeeDeeG commented Oct 15, 2024

By the way, if you want the commits to show a link to your username and profile on GItHub.com, you may want to update your git config user.email.

You can do like this git config --global user.email [numbers here][email protected].

(Documentation: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address#about-commit-email-addresses)

[EDIT: I typo'd noreply as norply. My apologies.]

If you don't prefer the commits link to your GitHub username and profile, then no need to worry about it.

@sogaiu
Copy link
Author

sogaiu commented Oct 15, 2024

Thanks so much for the consideration and detailed info!

I was aware of not showing up but I've considered this a bug on GitHub's part but did not know the specifics, TIL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants