Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Simplify Pulsar version string parsing in tests.yml #32

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

DeeDeeG
Copy link
Member

@DeeDeeG DeeDeeG commented Dec 19, 2023

Pursuant to a discussion on Discord: https://discord.com/channels/992103415163396136/1186519181592633434/1186570766343487528

I found a simpler, arguably more-readable way to parse the output of pulsar --version into just the Pulsar version (digits and dots).

After going back and forth a bit in Discord, this solution was requested to be posted as a PR.

I figured I'd go ahead and post it real quick before I forget and have to remind myself of the details tomorrow. So, here it is!

cc @confused-Techie

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for posting this!
Especially since we can see this works right away in our tests, looks like we should be good to merge right away.

Since while the previous solution worked the majority of the time, we did get strange behavior on the latest release turning the content into a date, rather than text, so this seems to be an awesome solution.

@confused-Techie confused-Techie merged commit 55dce3e into main Dec 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants