Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manual download section to add GitHub Actions and update Cirrus CI section. #239

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

Daeraxa
Copy link
Member

@Daeraxa Daeraxa commented Sep 16, 2023

Updates the manual download section which previously only detailed how to download binaries from Cirrus CI.

  • Adds a new GitHub Actions section and links to the pulsar-rolling-releases repo (as only people with read access to the main repo can download artifacts directly)
  • Added section to explain what is produced on GHA vs Cirrus
  • Updated a few areas to clarify things (like adding in architectures for binaries where they are distinct - previously this wasn't needed for Cirrus as architecture was selected before the binary).

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this overall looks great, would it make any sense to mention the download microservice here? Such as listing how to use the pulsar-rolling-release repo, then add on, but if you don't want to look manually you can use the download microservice? Just sense it also solves the problem of having to find a release with the right binaries

@Daeraxa
Copy link
Member Author

Daeraxa commented Sep 16, 2023

Well this is part of the whole Download page so to get to this bit one would have already gone past the explanation of the rolling releases and all the links to them, this section is very much buried at the bottom specifically for downloading manually despite all the previous instructions and links to make life easy.

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't get to this one sooner after the initial review.

Looks good and lets get this one merged!

@Daeraxa
Copy link
Member Author

Daeraxa commented Oct 17, 2023

Honestly I forgot about this, can I quickly get a fact check on:

  • Cirrus CI is only used for building Apple silicon (macOS M1/M2) and ARM
    Linux binaries. These are run less frequently (every other day).

I can't remember if that is true or not

@confused-Techie
Copy link
Member

@Daeraxa Very nearly. For all intents and purposes it's true, although technically it's not built every other day. It's Monday, Wednesday and Friday at 3PM.

So if you want to change that feel free

docs/download.md Outdated Show resolved Hide resolved
Co-authored-by: confused_techie <[email protected]>
@Daeraxa
Copy link
Member Author

Daeraxa commented Oct 18, 2023

Thanks, I think it is best for it to be factually correct.

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And to make sure we don't forget again, I'll go ahead and merge this one

@confused-Techie confused-Techie merged commit b24ccaa into pulsar-edit:main Oct 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants