-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update manual download section to add GitHub Actions and update Cirrus CI section. #239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this overall looks great, would it make any sense to mention the download
microservice here? Such as listing how to use the pulsar-rolling-release
repo, then add on, but if you don't want to look manually you can use the download microservice? Just sense it also solves the problem of having to find a release with the right binaries
Well this is part of the whole Download page so to get to this bit one would have already gone past the explanation of the rolling releases and all the links to them, this section is very much buried at the bottom specifically for downloading manually despite all the previous instructions and links to make life easy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I didn't get to this one sooner after the initial review.
Looks good and lets get this one merged!
Honestly I forgot about this, can I quickly get a fact check on:
I can't remember if that is true or not |
@Daeraxa Very nearly. For all intents and purposes it's true, although technically it's not built every other day. It's Monday, Wednesday and Friday at 3PM. So if you want to change that feel free |
Co-authored-by: confused_techie <[email protected]>
Thanks, I think it is best for it to be factually correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! And to make sure we don't forget again, I'll go ahead and merge this one
Updates the manual download section which previously only detailed how to download binaries from Cirrus CI.
pulsar-rolling-releases
repo (as only people with read access to the main repo can download artifacts directly)