Tweak wording for the "Manual download" info on the download page #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daeraxa
reviewed
Jul 19, 2024
docs/download.md
Outdated
Comment on lines
215
to
216
| Apple silicon and ARM Linux binaries are usually grouped together | ||
| in their own separate release from the x64 binaries, but sometimes not. |
There was a problem hiding this comment.
Suggested change
| Apple silicon and ARM Linux binaries are usually grouped together | |
| in their own separate release from the x64 binaries, but sometimes not. | |
| Apple silicon and ARM Linux binaries are usually, but not always, grouped together | |
| in their own separate release. |
|
I remember that conversation about "being logged in" etc. but didn't think we had pushed it to the site in that way. Thanks for noticing it and tidying it up. |
Daeraxa
reviewed
Jul 19, 2024
docs/download.md
Outdated
| @@ -190,28 +190,32 @@ You can bypass this by clicking "More info" then "Run anyway". | |||
| ## Manual download | |||
|
|
|||
| Binaries are built from a number of different branches and PRs but you should | |||
| stick to the **master** branch releases for the most stable ones unless you know | |||
| stick to the **`master`** branch releases for the most stable ones unless you know | |||
There was a problem hiding this comment.
Suggested change
| stick to the **`master`** branch releases for the most stable ones unless you know | |
| stick to the `master` branch releases for the most stable ones unless you know |
I'd probably remove the strong from this as I think converting it to inline code is enough to differentiate it.
|
If we update this PR from |
Co-authored-by: Daeraxa <[email protected]>
Co-authored-by: Daeraxa <[email protected]>
confused-Techie
approved these changes
Jul 23, 2024
|
Alright, thanks for the review! And somehow CI passed here, so perhaps the outdated Anyhow, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this text could use a bit of an update. See diff for details.