Upgrade 'pnpm/action-setup' to v4 in all CI workflows #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to PR 279, where specifically the test-deploy-pnpm.yaml workflow was updated.
|
Can't argue with any of that, makes perfect sense to me. |
Daeraxa
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #279, where specifically the test-deploy-pnpm.yaml workflow was updated.
Given that there is some deprecation or issue affecting the v2.x series of this action, it seems we must upgrade this version of the action. Only the test-deploy-pnpm workflow file was updated in #279, but apparently we have a separate workflow for production v.s. for testing PRs. For instance: the production deployment workflow failed when running for the new blog post PR landing. https://github.com/pulsar-edit/pulsar-edit.github.io/actions/runs/10013685234/job/27681843023
So, given we have demonstrated that the fix works via #279, this is just a follow-up to apply the fix in more places. Thanks to @confused-Techie for confirming this works as the fix. Reviews appreciated so production can go brr again.