Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last modern-Tree-sitter blog post #282

Merged

Conversation

savetheclocktower
Copy link
Contributor

I keep nipping at the edges of this post like it’s a bonsai tree. It’s time to show it to the world and think about something else.

Yes, it’s probably a bit too long. I’m not going to break it up into a two-part article, so if you have suggestions about what to omit, I’m all ears.

confused-Techie
confused-Techie previously approved these changes Sep 1, 2024
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always this was a fantastic read, and surely I've learned quite a bit from it.

Couldn't find any obvious formatting issues at all, so I see no reason to hold this back any longer, especially considering you've sat on it for a while.

It looks and reads amazingly, and really helped me understand more about Tree-sitter and the way we use it, which should be saying something since we are working on the same editor. Superb work here

@savetheclocktower
Copy link
Contributor Author

savetheclocktower commented Sep 1, 2024

Great! GitHub wants an approval. And once you've given it, go ahead and click the green button — I don't think I'm able to land PRs in this repo.

EDIT: Whoops, I dismissed your approval when I corrected a figure in the post! Sorry. Still, it's on you to merge it, so you should just be able to re-approve and click the button.

@confused-Techie confused-Techie merged commit 19bb2e4 into pulsar-edit:main Sep 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants