ppm: Bump ppm to commit 6981ce79e0efdd9bae1fac9bd1 #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contains the following PR's from the ppm repository: - 142 -- chore(deps): update dependency express to v4.20.0 [security] - 147 -- Eliminate trivial underscore - 137 -- deps: Bump node-gyp to latest ^10.2.0 for Python 3.12 compat - 149 -- Remove dependency on "request" package
DeeDeeG
force-pushed
the
bump-ppm-Feb-2025
branch
2 times, most recently
from
b669a4f to
c8e0d1f
Compare
Newer node-gyp (as a subdepenency of ppm) now supports Python 3.12! But drops support for Python 3.7, which Debian 10 "Buster" uses. Compile and install newer (not EOL, and supported by node-gyp) Python in the Debian Docker image we build the Linux bins on. (It's a bit slow and compute-intensive. The kind of thing best cached, so we don't have to wait and waste a bunch of watts/heat/emissions at some datacenter somewhere.) So we will do it once and cache the result in GitHub Actions cache. We can check SHA256 sum of Python tarball before using it, for safety. We always install Python compilation dependencies, as apparently we need these to do `make install` too, not just the main `make`.
DeeDeeG
force-pushed
the
bump-ppm-Feb-2025
branch
from
1b64056 to
5f6a1d7
Compare
|
I did the review on pulsar-edit/ppm#137 which is, as far as I can tell, the meat of this bump. Not going to do it again, but glad to see the CI issues have been worked out on this side. CI is also happy on the |
savetheclocktower
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains the following PR's from the ppm repository: