deps: Bump superstring to Pulsar's fork #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should help with building against newer NodeJS (18.x)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help with building against newer NodeJS (18.x)
Context:
The
masterbranch of our fork of superstring just has some slight changes to get it compiling on newer NodeJS/Electron, if I understand correctly.It still uses
nan, rather than jumping to other solutions likenode-api(AKAn-api) or WASM.This is for helping us get to a point where Pulsar is bootstrappable from a system with NodeJS 18 on it, rather than requiring us to hold back to NodeJS 16 to get Pulsar bootstrapped. (Unrelated to the "NodeJS version" Pulsar will actually use in production -- that is based on what's baked in to the Electron version we use. This is just about initially building our dependencies when we do
yarn install, strictly as a quirk of our bootstrap process before we rebuild the dependencies for Electron.)THIS IS A DRAFT WHILE I TEST OUT IF BUMPING THIS IN PULSAR CORE WOULD BASICALLY WORK, OR HAVE ANY ISSUES. IF IT'S NOT FIT FOR CORE, THEN THERE'S NO POINT COMMITTING IT TO THIS REPO'S MASTER BRANCH. PLEASE DON'T MERGE THIS AT THE MOMENT, THANKS.