Add bucket policy for uploads in testing #10395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean1588
force-pushed
the
zchase/uploads-bucket-policy
branch
from
2af413a to
1e2b496
Compare
sean1588
approved these changes
Jan 9, 2024
| @@ -3,11 +3,12 @@ config: | |||
| www.pulumi.com:addSecurityHeaders: "true" | |||
| www.pulumi.com:certificateArn: "arn:aws:acm:us-east-1:388588623842:certificate/9db6a76b-f7ba-465b-ab96-ce1d3b8ae02c" | |||
| www.pulumi.com:doEdgeRedirects: "true" | |||
| www.pulumi.com:hostedZone: www.pulumi.com | |||
There was a problem hiding this comment.
are all these values in the stack config files the same as they were before except for the marketingPortalStack? I guess it was the ordering that was switched up.
There was a problem hiding this comment.
Yeah they are all the same, I guess when I added the new config value it sorted them alphabetically.
cnunciato
added a commit
that referenced
this pull request
Jan 12, 2024
This reverts commit 435ac5a.
cnunciato
added a commit
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds a bucket policy to the testing bucket so we can upload files from an internal app.
Unreleased product version (optional)
Related issues (optional)