Skip to content

Re-seed weights in IaC concepts #15439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jkodroff
Copy link
Member

This should be a no-op from the perspective of the user - the menu items order should remain the same, but it will make future reordering easier.

@pulumi-bot
Copy link
Collaborator

@@ -220,7 +220,7 @@ By default, the Pulumi CLI uses a per-stack encryption key managed by Pulumi Clo
For example, this command sets a configuration variable named `dbPassword` to the plain-text value `S3cr37`:

```bash
$ pulumi config set --secret dbPassword S3cr37
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that our copy JavaScript knows to ignore the leading $. Is the proposal to move away from this everywhere? I suspect we do this in a lot of places (it's been our style since day one, probably my fault).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that we adopt the Google style guide recommendations here: https://developers.google.com/style/code-syntax#prompt ... basically, showing the $ prompt is always preferred (it's technically optional for single commands, but required for multiple commands in the same listing).

In general, I consider the Google style guide our base style, with some Pulumi-specific variations that override it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdownlint says you only include the $ if you show the output. I'm totally cool if we change this with a global config, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants