Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported LangVersion from dotnet example #2003

Merged
merged 8 commits into from
Jan 21, 2025
+9 −12
Merged

Remove unsupported LangVersion from dotnet example #2003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4abc6d8
Remove unsupported LangVersion from dotnet example
flostadler Jan 21, 2025
3eef443
Bump examples to dotnet 8
flostadler Jan 21, 2025
2af4417
Move back to 6.0.x
flostadler Jan 21, 2025
e3fb2a2
Try fixing installing the right dotnet version
flostadler Jan 21, 2025
e6968d1
Remove dotnet 11 language features
flostadler Jan 21, 2025
f3a4876
Remove unrelated changes
flostadler Jan 21, 2025
dc79802
remove language version
flostadler Jan 21, 2025
210d36c
Merge branch 'master' into flostadler/deactivate-dotnet-11
flostadler Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions examples/role-cs/MyStack.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,17 @@ public MyStack()
{
var testRole = new Role("role-test", new RoleArgs
{
AssumeRolePolicyDocument = """
{
"Version": "2012-10-17",
"Statement": [{
"Sid": "",
"Effect": "Allow",
"Principal": {
"Service": "ec2.amazonaws.com"
AssumeRolePolicyDocument = @"{
""Version"": ""2012-10-17"",
""Statement"": [{
""Sid"": """",
""Effect"": ""Allow"",
""Principal"": {
""Service"": ""ec2.amazonaws.com""
},
"Action": "sts:AssumeRole"
""Action"": ""sts:AssumeRole""
}]
}
""",
}",
Policies = new[]
{
new IamInputs.RolePolicyArgs
Expand Down
1 change: 0 additions & 1 deletion examples/role-cs/role-cs.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<LangVersion>11</LangVersion>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to bump this to net8.0 as well. We saw jobs fail in azure native due to the removal of 6.0 when runner images were updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that first, but turns out there's a bigger issue with most of the native providers: pulumi/ci-mgmt#1307
The installation is rather broken right now, before github upgraded the runners it installed 8.0 and then 3.1.301, right now it's installing 8.0, 6.0 then 3.1.301.

Somehow 6.0 is on the path before 8.0 now and that does not support LangVersion 11.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll first need to fix pulumi/ci-mgmt#1307 before being able to upgrade the target framework

<Nullable>enable</Nullable>
Expand Down
Loading