Skip to content

Commit

Permalink
Use v3 of actions/download-artifact (#1325)
Browse files Browse the repository at this point in the history
#1323 used v4 of the download
artifact action, which is incompatible with uploads using v3 of the
upload action. See
[FAQ](https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md#which-versions-of-the-artifacts-packages-are-compatible)
for compatibility matrix.

This resulted in the release step
[failing](https://github.com/pulumi/pulumi-awsx/actions/runs/9620941727/job/26540766895#step:4:36)
to download the uploaded artifact.

This PR also updates the pre-release workflow while we're at it.

Note: I've opted to use v3 of the download action to maintain
consistency with the rest of our GHA workflows. We can update to v4 in
the future.
  • Loading branch information
rquitales authored Jun 22, 2024
1 parent a4740be commit 847dcee
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 5 deletions.
25 changes: 22 additions & 3 deletions .github/workflows/pre-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -346,9 +346,28 @@ jobs:
uses: jaxxstorm/[email protected]
with:
repo: pulumi/pulumictl
- name: Add SDK version tag
run: git tag "sdk/v$PROVIDER_VERSION" && git push origin
"sdk/v$PROVIDER_VERSION"
- name: Download Go SDK
uses: actions/download-artifact@v3
with:
name: go-sdk.tar.gz
path: ${{ github.workspace }}/sdk/
- name: Uncompress Go SDK
run: tar -zxf ${{ github.workspace }}/sdk/go.tar.gz -C
${{ github.workspace }}/sdk/go
shell: bash
- uses: pulumi/publish-go-sdk-action@v1
with:
repository: ${{ github.repository }}
base-ref: ${{ github.sha }}
source: sdk
path: sdk
version: ${{ needs.version.outputs.version }}
additive: false
# Avoid including other language SDKs & artifacts in the commit
files: |
go.*
go/**
!*.tar.gz
name: prerelease
on:
push:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -345,10 +345,10 @@ jobs:
with:
repo: pulumi/pulumictl
- name: Download Go SDK
uses: actions/download-artifact@v4
uses: actions/download-artifact@v3
with:
name: go-sdk.tar.gz
path: $${{ github.workspace }}/sdk/
path: ${{ github.workspace }}/sdk/
- name: Uncompress Go SDK
run: tar -zxf ${{ github.workspace }}/sdk/go.tar.gz -C
${{ github.workspace }}/sdk/go
Expand Down

0 comments on commit 847dcee

Please sign in to comment.