Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record ts-lb-attach-ec2 upgrade test #1143

Merged
merged 5 commits into from
Nov 2, 2023
Merged

Record ts-lb-attach-ec2 upgrade test #1143

merged 5 commits into from
Nov 2, 2023

Conversation

danielrbradley
Copy link
Member

  • Replace peer-dependency with normal dependency.
  • This adds coverage of the awsx:lb:TargetGroupAttachment component.

@danielrbradley
Record ts-lb-attach-ec2 upgrade test
e5b3c5f 
- Replace peer-dependency with normal dependency.
@danielrbradley danielrbradley self-assigned this Nov 1, 2023
@danielrbradley
Force upgrade tests to always run in the same region
fdb1ece 
Ignore local configuration otherwise recordings might be in a different region and will force all resources to be replaced.
@danielrbradley
Re-record in correct region
0f783fa
@danielrbradley
Create VPC as part of the ASB attach test
6df14f7 
- Avoid indirectly relying on the ambient default VPC (happens if subnetIds is not specified on the LB).
- Update snapshots.
@danielrbradley
Avoid need to look up subnets
c67758c 
- When passing only the subnetIds, we then have to use an invoke to resolve the other required details which fails in replay mode.
- Instead, use the `subnets` property which contains the complete outputted subnet resources.
- However, this includes both the public and private subnets, so change the subnet specs to only include public subnets, and therefore we also have to disable the NAT gateway.
thomas11
thomas11 approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@thomas11 thomas11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit painful to rework the test around the upgrade testing but LGTM for now.

@danielrbradley danielrbradley merged commit 67ceb94 into master Nov 2, 2023
@danielrbradley danielrbradley deleted the upgrade-ts-lb-attach-ec2 branch November 2, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas11 thomas11 thomas11 approved these changes

@mikhailshilkov mikhailshilkov Awaiting requested review from mikhailshilkov

Assignees

@danielrbradley danielrbradley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielrbradley @thomas11