Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade aws to 6.9.0 #1162

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Upgrade aws to 6.9.0 #1162

merged 1 commit into from
Nov 21, 2023

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Nov 21, 2023

Should address #1156

@VenelinMartinov VenelinMartinov self-assigned this Nov 21, 2023
@VenelinMartinov VenelinMartinov requested a review from a team November 21, 2023 17:14
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @thomas11 Can you take a look?

Copy link
Contributor

@thomas11 thomas11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/pulumi/pulumi-awsx/blob/master/schemagen/pkg/gen/schema.go has the version range specs for all languages for the SDKs. For Python and C#, they're just 6.*. If you think we need v6.9, those should be edited as well. dependencies.Aws gives you access to the version defined in awsx/package.json.

@VenelinMartinov
Copy link
Contributor Author

Seems unlikely that the SDK should require the new version when there were no changes in awsx for this upgrade.

How can I make sure that the sdks work with the old one?

@mnlumi
Copy link
Contributor

mnlumi commented Nov 21, 2023

Is there any harm to ensuring all SDKs are at a minimum of 6.9.0? Would be good to be consistent to ensure we have this tags issue resolved across the board.

@VenelinMartinov
Copy link
Contributor Author

I believe the tags issue should be fixed by upgrading the AWS provider. https://github.com/pulumi/pulumi-aws/pull/2944/files has no sdk changes. I don't think upgrading the SDKs should be required and it would force users to upgrade the sdks too.

Do we generally do that?

@thomas11
Copy link
Contributor

I believe the tags issue should be fixed by upgrading the AWS provider. https://github.com/pulumi/pulumi-aws/pull/2944/files has no sdk changes. I don't think upgrading the SDKs should be required and it would force users to upgrade the sdks too.

Do we generally do that?

No. The Python and C# dependencies are at the minimum of v6.

For this change I don't think it's needed. It is a bit odd that we're inconsistent between languages. Although some, like Go, don't support ranges at all.

@VenelinMartinov VenelinMartinov merged commit fc171f7 into master Nov 21, 2023
9 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/upgrade_aws branch November 21, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants