Fix VPC legacy default subnet distribution #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Assuming all subnets are the same size is overly cautious and breaks some existing setups. - Maintain the new special case for single subnet layouts to use the whole of small VPCs. - This will now fail and require manual layout for smaller VPCs with either: - More than 1 private subnets - More than 2 public subnets - More than 1 public subnets and more than 4 isolated subnets
danielrbradley
force-pushed
the
fix-legacy-default-distribution
branch
from
e3c7aa7 to
78d87d4
Compare
t0yv0
approved these changes
Jan 30, 2024
mjeffryes
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1204