Fix breaking change in imageUri output of ecr.Image
#1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that #1278 introduced an (unreleased) breaking change in the
imageUrioutput ofecr.Image.Before upgrading to docker-build, the component returned URIs in the form of
ACCOUNT_ID.dkr.ecr.REGION.amazonaws.com/REPOSITORY_NAME@sha256:1234567890123456789012345678901234567890123456789012345678901234.After the update it returns them in the following form
ACCOUNT_ID.dkr.ecr.REGION.amazonaws.com/REPOSITORY_NAME:TAG_NAME@sha256:1234567890123456789012345678901234567890123456789012345678901234. (NOTE: they include the tag name now)While it seems like an innocent change, it breaks the integration with lambda functions. AWS Lambda expects an image URI without the TAG.
The change proposed in this PR adds post processing for the image ref in order to strip the tag from the URI. Additionally it extends the upgrade test to assert on this behavior.
Relates to #1349