-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Entra PIM custom resource #3663
Draft
thomas11
wants to merge
10
commits into
master
Choose a base branch
from
tkappler/pim2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thomas11
commented
Oct 23, 2024
- Don't require custom resources to implement Read to implement Create
- WIP Custom resource for PIM role management policies (ARM, not AAD).
- First working iteration in a local test. Some TODOs and missing tests.
- Update with restoring deleted rules to their original state
- Need to preserve the original state across updates
- Complete e2e integration test for role management policies, with external validation via azure SDK
- Make sure original state survives all roundtrips
- regenerate
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
New functions:
|
thomas11
force-pushed
the
tkappler/pim2
branch
from
October 24, 2024 16:24
e75e3f2
to
5c2b57a
Compare
thomas11
force-pushed
the
tkappler/pim2
branch
from
October 24, 2024 22:37
5c2b57a
to
5cba82d
Compare
thomas11
force-pushed
the
tkappler/pim2
branch
from
November 5, 2024 09:20
5cba82d
to
09b20c6
Compare
thomas11
force-pushed
the
tkappler/pim2
branch
from
November 6, 2024 06:44
09b20c6
to
0578864
Compare
Looks reasonable, except that the Delete operation in the spec isn't actually implemented. Sigh.
…rnal validation via azure SDK
…oesn't know about path properties
thomas11
force-pushed
the
tkappler/pim2
branch
from
November 7, 2024 09:53
0578864
to
179c7f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.