Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Entra PIM custom resource #3663

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Azure Entra PIM custom resource #3663

wants to merge 10 commits into from

Commits on Nov 7, 2024

  1. Don't require custom resources to implement Read to implement Create

    @thomas11
    thomas11 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c880504 View commit details
    Browse the repository at this point in the history

  2. WIP Custom resource for PIM role management policies (ARM, not AAD). 

    Looks reasonable, except that the Delete operation in the spec isn't
actually implemented. Sigh.
    @thomas11
    thomas11 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    fedd372 View commit details
    Browse the repository at this point in the history

  3. First working iteration in a local test. Some TODOs and missing tests.

    @thomas11
    thomas11 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    4c79ef2 View commit details
    Browse the repository at this point in the history

  4. Update with restoring deleted rules to their original state

    @thomas11
    thomas11 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    fd05887 View commit details
    Browse the repository at this point in the history

  5. Need to preserve the original state across updates

    @thomas11
    thomas11 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    dd20bba View commit details
    Browse the repository at this point in the history

  6. Complete e2e integration test for role management policies, with exte… 

    …rnal validation via azure SDK
    @thomas11
    thomas11 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a269ae8 View commit details
    Browse the repository at this point in the history

  7. Make sure original state survives all roundtrips

    @thomas11
    thomas11 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    4f0f731 View commit details
    Browse the repository at this point in the history

  8. regenerate

    @thomas11
    thomas11 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    07741a4 View commit details
    Browse the repository at this point in the history

  9. Debug logging for integration test

    @thomas11
    thomas11 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    4dbfdb5 View commit details
    Browse the repository at this point in the history

  10. Change 'Unrecognized properties' from error to log message since it d… 

    …oesn't know about path properties
    @thomas11
    thomas11 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    179c7f2 View commit details
    Browse the repository at this point in the history